Cancel RPC tasks and actor machinery greedily #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of "scheduling" cancel tasks in response to requests just immediately invoke (via `await <target>`) the appropriate cancel method. This completely avoids the case of a "cancel request task being cancelled". There should be no downside to this approach should be less racy then prior.
goodboy
added
IPC and transport
supervision
cancellation
|
Replaced by #245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of "scheduling" cancel tasks in response to requests just
immediately invoke (via
await <target>) the appropriate cancel method.This completely avoids the case of a "cancel request task being
cancelled". There should be no downside to this approach should be less
racy then prior.
Turns out this actually causes slow downs in certain tests, not sure where yet (likely during tear downs obviously) and not sure if the reduction in racyness is worth that slowdown.